Overhaul notification parsing #12

Open
VD15 wants to merge 4 commits from 9_fix_bot_app_py into dev
VD15 commented 16 hours ago
Collaborator
  • Move notification parsing to its own file
  • Add config options for NOTIFICATION_POLL_INTERVAL and NOTIFICATION_BATCH_SIZE
  • Removed instances of global variables
  • Fix the exception loop hypothesized in #9
* Move notification parsing to its own file * Add config options for NOTIFICATION_POLL_INTERVAL and NOTIFICATION_BATCH_SIZE * Removed instances of global variables * Fix the exception loop hypothesized in #9
VD15 added 3 commits 16 hours ago
VD15 added the
Refactoring
label 16 hours ago
VD15 changed target branch from dev to master 16 hours ago
VD15 changed target branch from master to dev 16 hours ago
waifu requested review from waifu 15 hours ago
Owner

It's giving me some issues by repeatedly parsing the same notification.

It's giving me some issues by repeatedly parsing the same notification.
Poster
Collaborator

Interestingly, I can only recreate intermittently. Seems I made an incorrect assumption about misskey's API: sometimes it'll just include the notification you specify as since_id and sometimes it won't. I'll add another check for notification id as we can't rely on the API to filter it, it seems.

image image

Interestingly, I can only recreate intermittently. Seems I made an incorrect assumption about misskey's API: sometimes it'll just include the notification you specify as since_id and sometimes it won't. I'll add another check for notification id as we can't rely on the API to filter it, it seems. ![image](/attachments/e17cfed7-8bd2-4eb2-9b15-d0b593d0a4c6) ![image](/attachments/84445b6d-d60b-40c5-8292-6aaf48a0af4f)
VD15 added 1 commit 3 hours ago

Reviewers

waifu was requested for review 15 hours ago
This pull request can be merged automatically.
You are not authorized to merge this pull request.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: waifu/kemoverse#12
Loading…
There is no content yet.