waifu
/
kemoverse
3
2
Fork 1
Code Issues 6 Pull Requests 1 Packages Projects Releases Wiki Activity
Labels Milestones

Overhaul notification parsing #12

Merged
waifu merged 4 commits from 9_fix_bot_app_py into dev 7 hours ago
Conversation 2 Commits 4 Files Changed 4
VD15 commented 2 days ago
Collaborator
  • Move notification parsing to its own file
  • Add config options for NOTIFICATION_POLL_INTERVAL and NOTIFICATION_BATCH_SIZE
  • Removed instances of global variables
  • Fix the exception loop hypothesized in #9
* Move notification parsing to its own file * Add config options for NOTIFICATION_POLL_INTERVAL and NOTIFICATION_BATCH_SIZE * Removed instances of global variables * Fix the exception loop hypothesized in #9
VD15 added 3 commits 2 days ago
VD15 added the
Refactoring
 label 2 days ago
VD15 changed target branch from dev to master 2 days ago
VD15 changed target branch from master to dev 2 days ago
waifu requested review from waifu 2 days ago
waifu commented 1 day ago
Owner

It's giving me some issues by repeatedly parsing the same notification.

It's giving me some issues by repeatedly parsing the same notification.
Screenshot from 2025-05-19 22-27-18.png
11 KiB
Screenshot from 2025-05-19 22-29-10.png
134 KiB
VD15 commented 1 day ago
Poster
Collaborator

Interestingly, I can only recreate intermittently. Seems I made an incorrect assumption about misskey's API: sometimes it'll just include the notification you specify as since_id and sometimes it won't. I'll add another check for notification id as we can't rely on the API to filter it, it seems.

image image

Interestingly, I can only recreate intermittently. Seems I made an incorrect assumption about misskey's API: sometimes it'll just include the notification you specify as since_id and sometimes it won't. I'll add another check for notification id as we can't rely on the API to filter it, it seems. ![image](/attachments/e17cfed7-8bd2-4eb2-9b15-d0b593d0a4c6) ![image](/attachments/84445b6d-d60b-40c5-8292-6aaf48a0af4f)
image.png
13 KiB
image.png
11 KiB
🚀 1
VD15 added 1 commit 1 day ago
waifu approved these changes 7 hours ago
waifu left a comment
Owner

working in production as intended

working in production as intended
waifu merged commit e53bd87d81 into dev 7 hours ago

Reviewers

waifu approved these changes 7 hours ago
The pull request has been merged as e53bd87d81.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
waifu
Labels
Apply labels
Clear labels
Bug Feature Refactoring Won't do
No Label Bug Feature Refactoring Won't do
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: waifu/kemoverse#12
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '9_fix_bot_app_py'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes