waifu/kemoverse
waifu/kemoverse
3
2
Fork 3
Code Issues 13 Pull requests 4 Projects 1 Releases Packages Wiki Activity

Overhaul notification parsing #12

Merged
waifu merged 4 commits from 9_fix_bot_app_py into dev 2025-05-20 20:28:51 -07:00
Conversation 2 Commits 4 Files changed 4 +133 -110
VD15 commented 2025-05-19 11:38:51 -07:00
Collaborator
Copy link
  • Move notification parsing to its own file
  • Add config options for NOTIFICATION_POLL_INTERVAL and NOTIFICATION_BATCH_SIZE
  • Removed instances of global variables
  • Fix the exception loop hypothesized in #9
* Move notification parsing to its own file * Add config options for NOTIFICATION_POLL_INTERVAL and NOTIFICATION_BATCH_SIZE * Removed instances of global variables * Fix the exception loop hypothesized in #9
VD15 added 3 commits 2025-05-19 11:38:53 -07:00 
Reviewed-on: #10
VD15 added the
Refactoring
 label 2025-05-19 11:38:58 -07:00
VD15 changed target branch from dev to master 2025-05-19 11:40:15 -07:00
VD15 changed target branch from master to dev 2025-05-19 11:41:28 -07:00
requested review from waifu 2025-05-19 13:13:59 -07:00
waifu commented 2025-05-19 18:08:54 -07:00
Owner
Copy link

It's giving me some issues by repeatedly parsing the same notification.

It's giving me some issues by repeatedly parsing the same notification.
Screenshot from 2025-05-19 22-27-18.png
11 KiB
Screenshot from 2025-05-19 22-29-10.png
134 KiB
Screenshot from 2025-05-19 22-27-18.png Screenshot from 2025-05-19 22-29-10.png
VD15 commented 2025-05-20 00:42:47 -07:00
Author
Collaborator
Copy link

Interestingly, I can only recreate intermittently. Seems I made an incorrect assumption about misskey's API: sometimes it'll just include the notification you specify as since_id and sometimes it won't. I'll add another check for notification id as we can't rely on the API to filter it, it seems.

image image

Interestingly, I can only recreate intermittently. Seems I made an incorrect assumption about misskey's API: sometimes it'll just include the notification you specify as since_id and sometimes it won't. I'll add another check for notification id as we can't rely on the API to filter it, it seems. ![image](/attachments/e17cfed7-8bd2-4eb2-9b15-d0b593d0a4c6) ![image](/attachments/84445b6d-d60b-40c5-8292-6aaf48a0af4f)
image.png
13 KiB
image.png
11 KiB
🚀 1
VD15 added 1 commit 2025-05-20 01:00:42 -07:00
waifu approved these changes 2025-05-20 20:28:44 -07:00
waifu left a comment
Owner
Copy link

working in production as intended

working in production as intended
waifu merged commit e53bd87d81 into dev 2025-05-20 20:28:51 -07:00
Sign in to join this conversation.
Reviewers
No reviewers
waifu
Labels
Clear labels   
Bug

Something's Not Working Right

  
Feature

New Functionality For The Bot

  
Feedback Wanted

Looking for Feedback

  
Refactoring

Codebase Changes

  
Won't Do

Nah Mate.

No labels
Bug
Feature
Feedback Wanted
Refactoring
Won't Do
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: waifu/kemoverse#12
No description provided.
Delete branch "9_fix_bot_app_py"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?