Explicit Account Creation/Deletion #35
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Currently, players are implicitly added to the database the first time they roll. This has the potential to be a GDPR concern, as we're not obtaining consent from users to store their usernames, which could count as personal information under the GDPR, as some weirdos use their (full) real name as their fedi handle.
I don't think it's necessary to draft a whole ass privacy policy at this point, but I do think it's necessary to add an explicit sign-up step as well as an option for players to delete their account should they wish.
get_or_create_user()
into two functions:get_player()
andinsert_player()
signup
command to the bot that adds the player to the DB. We can later extend thisgenerate_response()
to check if the player exists in the DB and instruct players who have not signed up yet to run thesignup
command.delete_account
command to the bot that tells the player that deleting their account is super duper permenant and all that, prompting them to confirm they wish to delete their account.delete_player()
function that deletes a player and all their pulls from the DB.I'm thinking that people could exploit this by creating and deleting the account immediately to farm for rolls specially if we give bonus rolls at the beginning. Perhaps keeping the username inside the blacklist when it gets deleted, only for 24 hours then deleting it (completely) could solve the issue. We do keep the whitelist to defer from bad actors but some instances have open registrations which could make things difficult. I'll set another issue to have a limit on registrations per hour per instance, that should be enough.
Closing as the necesary changes got merged on #42, and the issue #43 would solve the registration limit. Thanks kings