Reconsider gacha_response responsibilites #3

New issue

Closed

opened 2025-05-15 18:41:15 -07:00 by nai · 0 comments

nai commented

2025-05-15 18:41:15 -07:00

Collaborator

https://git.waifuism.life/waifu/kemoverse/src/branch/master/bot/parsing.py#L53

Remember the video I showed you, how it's easier to maintain large enough components of the system if they have clearer responsibility that's easier to read and poinpoint bugs.

Acceptance Criteria:

Move away any game-database logic away from the parser
It should only convert notification data into internal command, that gets returned into bot_app and from there bot_app should dispatch which next module to call

https://git.waifuism.life/waifu/kemoverse/src/branch/master/bot/parsing.py#L53 Remember the video I showed you, how it's easier to maintain large enough components of the system if they have clearer responsibility that's easier to read and poinpoint bugs. Acceptance Criteria: - Move away any game-database logic away from the parser - It should only convert notification data into internal command, that gets returned into bot_app and from there bot_app should dispatch which next module to call