Reconsider gacha_response responsibilites #3

Open
opened 5 days ago by nai · 0 comments
nai commented 5 days ago
Collaborator

https://git.waifuism.life/waifu/kemoverse/src/branch/master/bot/parsing.py#L53

Remember the video I showed you, how it's easier to maintain large enough components of the system if they have clearer responsibility that's easier to read and poinpoint bugs.

Acceptance Criteria:

  • Move away any game-database logic away from the parser
  • It should only convert notification data into internal command, that gets returned into bot_app and from there bot_app should dispatch which next module to call
https://git.waifuism.life/waifu/kemoverse/src/branch/master/bot/parsing.py#L53 Remember the video I showed you, how it's easier to maintain large enough components of the system if they have clearer responsibility that's easier to read and poinpoint bugs. Acceptance Criteria: - Move away any game-database logic away from the parser - It should only convert notification data into internal command, that gets returned into bot_app and from there bot_app should dispatch which next module to call
nai added the
Refactoring
label 5 days ago
waifu was assigned by nai 5 days ago
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: waifu/kemoverse#3
Loading…
There is no content yet.